[chore](dep)upgrade netty and hadoop#57226
Merged
CalvinKirs merged 6 commits intoapache:masterfrom Nov 3, 2025
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 16495 ms |
TPC-DS: Total hot run time: 106778 ms |
Member
Author
|
run buildall |
ClickBench: Total hot run time: 28.01 s |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Member
Author
|
run buildall |
morningman
previously approved these changes
Oct 31, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Member
Author
|
run buildall |
TPC-DS: Total hot run time: 189690 ms |
ClickBench: Total hot run time: 27.85 s |
Member
Author
|
run buildall |
TPC-DS: Total hot run time: 190007 ms |
ClickBench: Total hot run time: 27.84 s |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
ClickBench: Total hot run time: 27.73 s |
Member
Author
|
run buildall |
1 similar comment
Member
Author
|
run buildall |
ClickBench: Total hot run time: 27.94 s |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
morningman
approved these changes
Nov 1, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
hubgeter
approved these changes
Nov 3, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
upgrade netty and hadoop
github-actions bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
upgrade netty and hadoop
CalvinKirs
added a commit
that referenced
this pull request
Nov 5, 2025
yiguolei
pushed a commit
that referenced
this pull request
Dec 2, 2025
CalvinKirs
added a commit
that referenced
this pull request
Dec 2, 2025
…mpatible services. (#58566) … This PR addresses an issue related to AWS SDK for Java v2 S3 client behavior described in: aws/aws-sdk-java-v2#5805 Starting from newer versions of the SDK, the S3 client introduces unexpected behavior that causes our application to fail during normal S3 operations. Due to this problem, we were forced to downgrade aws-s3 from the latest version to 2.29.x, which restored correct functionality. The regression affects stability in our production environment and prevents us from upgrading the SDK. #57226
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
…mpatible services. (#58566) … This PR addresses an issue related to AWS SDK for Java v2 S3 client behavior described in: aws/aws-sdk-java-v2#5805 Starting from newer versions of the SDK, the S3 client introduces unexpected behavior that causes our application to fail during normal S3 operations. Due to this problem, we were forced to downgrade aws-s3 from the latest version to 2.29.x, which restored correct functionality. The regression affects stability in our production environment and prevents us from upgrading the SDK. #57226
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
…mpatible services. (#58566) … This PR addresses an issue related to AWS SDK for Java v2 S3 client behavior described in: aws/aws-sdk-java-v2#5805 Starting from newer versions of the SDK, the S3 client introduces unexpected behavior that causes our application to fail during normal S3 operations. Due to this problem, we were forced to downgrade aws-s3 from the latest version to 2.29.x, which restored correct functionality. The regression affects stability in our production environment and prevents us from upgrading the SDK. #57226
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
…mpatible services. (apache#58566) … This PR addresses an issue related to AWS SDK for Java v2 S3 client behavior described in: aws/aws-sdk-java-v2#5805 Starting from newer versions of the SDK, the S3 client introduces unexpected behavior that causes our application to fail during normal S3 operations. Due to this problem, we were forced to downgrade aws-s3 from the latest version to 2.29.x, which restored correct functionality. The regression affects stability in our production environment and prevents us from upgrading the SDK. apache#57226
16 tasks
CalvinKirs
added a commit
that referenced
this pull request
Jan 7, 2026
…9512) ### What problem does this PR solve? When creating an AWS SDK V2 async client (e.g. S3AsyncClient), the SDK requires a thread pool to manage asynchronous task scheduling, timeouts, and retries (e.g. ScheduledExecutorService or async executor). If no executor is explicitly provided, the AWS SDK creates its own internal thread pool, which is expected to be shut down when client.close() is invoked. ### Issue In Doris, when using Paimon Catalog, some catalog implementations provide an empty close() method. As a result, when a user executes DROP CATALOG: starting with Hadoop 3.4, the AWS SDK was upgraded to v2. Since #57226 upgraded HDFS to 3.4.2, the catalog runs into this issue. Some Catalog instance is discarded,AWS SDK client.close() is never called,The internally created thread pool cannot be shut down. This leads to a thread leak FYI aws/aws-sdk-java-v2#3746 ### Problem Analysis The lifecycle of Catalog creation and destruction is complex and managed internally by Paimon Doris cannot reliably intervene in the call chain to enforce AWS SDK client.close() If each Catalog creates its own AWS SDK client with an internally managed thread pool, threads will continue to leak as Catalogs are repeatedly created and dropped ### Solution This PR resolves the issue by introducing a shared executor strategy: A Doris-managed shared thread pool is explicitly passed when creating AWS SDK V2 clients This prevents the AWS SDK from implicitly creating per-client internal thread pools The lifecycle of the executor is fully controlled by Doris and no longer depends on Paimon Catalog’s close() implementation With this approach, even if a Paimon Catalog’s close() method is a no-op, the system will no longer leak threads. None
zzzxl1993
pushed a commit
to zzzxl1993/doris
that referenced
this pull request
Jan 13, 2026
…ache#59512) ### What problem does this PR solve? When creating an AWS SDK V2 async client (e.g. S3AsyncClient), the SDK requires a thread pool to manage asynchronous task scheduling, timeouts, and retries (e.g. ScheduledExecutorService or async executor). If no executor is explicitly provided, the AWS SDK creates its own internal thread pool, which is expected to be shut down when client.close() is invoked. ### Issue In Doris, when using Paimon Catalog, some catalog implementations provide an empty close() method. As a result, when a user executes DROP CATALOG: starting with Hadoop 3.4, the AWS SDK was upgraded to v2. Since apache#57226 upgraded HDFS to 3.4.2, the catalog runs into this issue. Some Catalog instance is discarded,AWS SDK client.close() is never called,The internally created thread pool cannot be shut down. This leads to a thread leak FYI aws/aws-sdk-java-v2#3746 ### Problem Analysis The lifecycle of Catalog creation and destruction is complex and managed internally by Paimon Doris cannot reliably intervene in the call chain to enforce AWS SDK client.close() If each Catalog creates its own AWS SDK client with an internally managed thread pool, threads will continue to leak as Catalogs are repeatedly created and dropped ### Solution This PR resolves the issue by introducing a shared executor strategy: A Doris-managed shared thread pool is explicitly passed when creating AWS SDK V2 clients This prevents the AWS SDK from implicitly creating per-client internal thread pools The lifecycle of the executor is fully controlled by Doris and no longer depends on Paimon Catalog’s close() implementation With this approach, even if a Paimon Catalog’s close() method is a no-op, the system will no longer leak threads. None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.